Re: [PATCH v2 0/2] do_compare_entry: use already-computed path

2015-12-22 Thread Junio C Hamano
David Turner writes: > On Mon, 2015-12-21 at 15:34 -0800, Junio C Hamano wrote: >> Great. Thanks, will queue w/o 1/2 (though I do not think it would >> hurt). >> >> On Mon, Dec 21, 2015 at 3:33 PM, David Turner < >> dtur...@twopensource.com> wrote: >> > On Mon, 2015-12-21 at 15:27 -0800, Junio C

Re: [PATCH v2 0/2] do_compare_entry: use already-computed path

2015-12-21 Thread David Turner
On Mon, 2015-12-21 at 15:34 -0800, Junio C Hamano wrote: > Great. Thanks, will queue w/o 1/2 (though I do not think it would > hurt). > > On Mon, Dec 21, 2015 at 3:33 PM, David Turner < > dtur...@twopensource.com> wrote: > > On Mon, 2015-12-21 at 15:27 -0800, Junio C Hamano wrote: > > > Thanks. D

Re: [PATCH v2 0/2] do_compare_entry: use already-computed path

2015-12-21 Thread David Turner
On Mon, 2015-12-21 at 15:27 -0800, Junio C Hamano wrote: > Thanks. Does the number still stay at 25% improvement? Yes. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-i

Re: [PATCH v2 0/2] do_compare_entry: use already-computed path

2015-12-21 Thread Junio C Hamano
Thanks. Does the number still stay at 25% improvement? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 0/2] do_compare_entry: use already-computed path

2015-12-21 Thread David Turner
This version strdups the path to avoid it getting mutated. Problem noted by Junio. David Turner (2): traverse_info: make mostly const do_compare_entry: use already-computed path builtin/merge-tree.c | 2 +- cache-tree.c | 4 ++-- cache-tree.h | 2 +- t/t4010-