Re: [PATCH v2 0/2] Date test code clean-up

2019-09-13 Thread Junio C Hamano
Jeff King writes: > On Wed, Sep 11, 2019 at 09:11:00PM -0700, Stephen P. Smith wrote: > >> Range Diff: >> 1: f4170ad553 ! 1: e2b8322d58 Quit passing 'now' to date code >> [...] > > Thanks, this version addresses all of my concerns from v1 (and overall > looks good). Yup, the result of applying

Re: [PATCH v2 0/2] Date test code clean-up

2019-09-12 Thread Jeff King
On Wed, Sep 11, 2019 at 09:11:00PM -0700, Stephen P. Smith wrote: > Range Diff: > 1: f4170ad553 ! 1: e2b8322d58 Quit passing 'now' to date code > [...] Thanks, this version addresses all of my concerns from v1 (and overall looks good). -Peff

[PATCH v2 0/2] Date test code clean-up

2019-09-11 Thread Stephen P. Smith
As part of a previous patch submission[1], a cleanup patch was suggested to remove a now unnecessary passing of a date environment variable to the production code. While the two patches in the set could easily be submitted as a single patch, I split the removal of the getenv() call into a second p