Re: [PATCH v2 0/2] Config conditional include

2016-06-28 Thread Duy Nguyen
On Tue, Jun 28, 2016 at 10:28 PM, Jeff King wrote: > On Tue, Jun 28, 2016 at 07:26:39PM +0200, Nguyễn Thái Ngọc Duy wrote: > >> There's a surprise about core.ignorecase. We are matching paths, so we >> should match case-insensitively if core.ignorecase tells us so. And it >> gets a bit tricky if c

Re: [PATCH v2 0/2] Config conditional include

2016-06-28 Thread Junio C Hamano
Honestly, I'd really prefer to see those with topics in 'pu' that has seen reviews but not yet updated to go back to and polish them to help move things forward, with the goal to have them in 'next' sooner so that we can have fixes and features that are sufficiently vetted and tested in the next re

Re: [PATCH v2 0/2] Config conditional include

2016-06-28 Thread Jeff King
On Tue, Jun 28, 2016 at 10:51:15PM +0200, Matthieu Moy wrote: > Jeff King writes: > > > On Tue, Jun 28, 2016 at 07:26:39PM +0200, Nguyễn Thái Ngọc Duy wrote: > > > >> There's a surprise about core.ignorecase. We are matching paths, so we > >> should match case-insensitively if core.ignorecase te

Re: [PATCH v2 0/2] Config conditional include

2016-06-28 Thread Matthieu Moy
Jeff King writes: > On Tue, Jun 28, 2016 at 07:26:39PM +0200, Nguyễn Thái Ngọc Duy wrote: > >> There's a surprise about core.ignorecase. We are matching paths, so we >> should match case-insensitively if core.ignorecase tells us so. And it >> gets a bit tricky if core.ignorecase is defined in the

Re: [PATCH v2 0/2] Config conditional include

2016-06-28 Thread Jeff King
On Tue, Jun 28, 2016 at 07:26:39PM +0200, Nguyễn Thái Ngọc Duy wrote: > There's a surprise about core.ignorecase. We are matching paths, so we > should match case-insensitively if core.ignorecase tells us so. And it > gets a bit tricky if core.ignorecase is defined in the same config > file. I don

[PATCH v2 0/2] Config conditional include

2016-06-28 Thread Nguyễn Thái Ngọc Duy
Second try. The anchoring rules now look a lot better. I cherry picked Jeff's skip_prefix_mem() for now to avoid dependency. There's a surprise about core.ignorecase. We are matching paths, so we should match case-insensitively if core.ignorecase tells us so. And it gets a bit tricky if core.ignor