On Tue, May 01, 2018 at 05:08:27PM -0700, Elijah Newren wrote:
> Eckhard, can you add some comments to your commit message mentioning
> the email pointed to by Junio about break detection and rename
> detection being unsafe to use together, as well as the inconsistencies
> in break detection betwee
On 5/1/2018 8:08 PM, Elijah Newren wrote:
On Tue, May 1, 2018 at 4:11 PM, Junio C Hamano wrote:
Elijah Newren writes:
I also just realized that in addition to status being inconsistent
with diff/log/show, it was also inconsistent with itself -- it handles
staged and unstaged changes dif
On Tue, May 1, 2018 at 4:11 PM, Junio C Hamano wrote:
> Elijah Newren writes:
>
>> I'm not certain what the default should be, but I do believe that it
>> should be consistent between these commands. I lean towards
>> considering break detection being on by default a good thing, but
>> there are
Elijah Newren writes:
> I'm not certain what the default should be, but I do believe that it
> should be consistent between these commands. I lean towards
> considering break detection being on by default a good thing, but
> there are some interesting issues to address:
> - there is no knob to
On Tue, May 01, 2018 at 02:23:51PM +0200, Matthieu Moy wrote:
> I'm fine with it as-is. Before your "fix", the config was ignored
> because overwritten by init_diff_ui_defaults() after reading the
> config, so effect of your change is indeed what the commit message
> describes.
>
> I'm often think
On Tue, May 1, 2018 at 5:23 AM, Matthieu Moy wrote:
> "Eckhard Maaß" :
>
>> On Tue, May 01, 2018 at 01:09:06PM +0200, Matthieu Moy wrote:
>> > That init_diff_ui_defaults() should indeed have been before
>> > git_config() from the beginning. My bad, I'm the one who
>> > misplaced it apparently :-(.
"Eckhard Maaß" :
> On Tue, May 01, 2018 at 01:09:06PM +0200, Matthieu Moy wrote:
> > That init_diff_ui_defaults() should indeed have been before
> > git_config() from the beginning. My bad, I'm the one who
> > misplaced it apparently :-(.
> Should I have done this "bug fix" in a separate commit o
On Tue, May 01, 2018 at 01:09:06PM +0200, Matthieu Moy wrote:
> That init_diff_ui_defaults() should indeed have been before
> git_config() from the beginning. My bad, I'm the one who
> misplaced it apparently :-(.
Should I have done this "bug fix" in a separate commit or mention it in
the commit m
On Tue, May 01, 2018 at 01:00:54PM +0200, Ævar Arnfjörð Bjarmason wrote:
> So didn't we use diff heuristics to begin with, and then regressed? I've
> only given this a skimming, but it's useful to have that sort of
> historical context mentioned explicitly with commit ids.
Sorry for not making thi
"Eckhard S. Maaß" wrote:
> Since the very beginning, git status behaved differently for rename
> detection than other rename aware commands like git log or git show as
> it has the use of rename hard coded into it.
My understanding is that the succession of events went stg like:
1) invent the r
On Tue, May 01 2018, Eckhard S. Maaß wrote:
> Since the very beginning, git status behaved differently for rename
> detection than other rename aware commands like git log or git show as
> it has the use of rename hard coded into it.
Can you elaborate on this? It seems initial rename detection
Since the very beginning, git status behaved differently for rename
detection than other rename aware commands like git log or git show as
it has the use of rename hard coded into it. After 5404c116aa ("diff:
activate diff.renames by default", 2016-02-25) the default behaves the
same by coincidenc
12 matches
Mail list logo