Re: [PATCH v2] utf8.c: print warning about iconv errors

2015-08-17 Thread Junio C Hamano
Jeff King writes: > On Fri, Aug 14, 2015 at 03:35:58PM -0700, Junio C Hamano wrote: > >> Max Kirillov writes: >> >> > * do not limit number of warnings - does not worth complicating the code >> >> Unless the warning leads to a quick "die()", wouldn't this make Git >> unusable by spewing a "fal

Re: [PATCH v2] utf8.c: print warning about iconv errors

2015-08-17 Thread Jeff King
On Fri, Aug 14, 2015 at 03:35:58PM -0700, Junio C Hamano wrote: > Max Kirillov writes: > > > * do not limit number of warnings - does not worth complicating the code > > Unless the warning leads to a quick "die()", wouldn't this make Git > unusable by spewing a "falling back to verbatim copy" f

Re: [PATCH v2] utf8.c: print warning about iconv errors

2015-08-14 Thread Junio C Hamano
Max Kirillov writes: > * do not limit number of warnings - does not worth complicating the code Unless the warning leads to a quick "die()", wouldn't this make Git unusable by spewing a "falling back to verbatim copy" for each and every line of the message of a commit that has 'encoding' element

[PATCH v2] utf8.c: print warning about iconv errors

2015-08-14 Thread Max Kirillov
If reencoding a text data from one encoding to another fails, the original version is used insted. Currently there is no warning about failed reencoding, which can have an undesired outcome that returned data is incorrect but user is not aware about it. Add printing warning when conversion fails.