Re: [PATCH v2] upload-pack.c: use of parse-options API

2016-05-20 Thread Junio C Hamano
Matthieu Moy writes: >> Using "format-patch --patience" or some other diff option, and pick >> the best one to give to "send-email" would indeed be a way to do so. > > It's a matter of taste. My flow is "send-email-only", I do as much as > possible in-tree, and when I notice something to do durin

Re: [PATCH v2] upload-pack.c: use of parse-options API

2016-05-19 Thread Matthieu Moy
Junio Hamano wrote: > Matthieu Moy writes: > > > antoine.qu...@ensimag.grenoble-inp.fr wrote: > >> come from the commit (gmane/131517) > > > > Please, use a real commit id instead of a Gmane link. > > > > We don't know how long Gmane will remain up, but a self > > reference from Git's history to

Re: [PATCH v2] upload-pack.c: use of parse-options API

2016-05-19 Thread Matthieu Moy
Junio C Hamano wrote: > Encouraging use of "send-email" with "--patience" is a losing > approach if your goal is to present more reviewable diff, isn't it? > Using "send-email" as if it is a front-end of "format-patch" means > you lose the opportunity for the final proof-reading (not just > finding

Re: [PATCH v2] upload-pack.c: use of parse-options API

2016-05-19 Thread Junio C Hamano
Matthieu Moy writes: >> +if (argc != 1) >> +usage_with_options(upload_pack_usage, options); >> >> -setup_path(); >> +if (timeout) >> +daemon_mode = 1; >> >> -dir = argv[i]; >> +setup_path(); >> >> +dir = argv[0]; > > Not a problem with your co

Re: [PATCH v2] upload-pack.c: use of parse-options API

2016-05-19 Thread Junio C Hamano
Matthieu Moy writes: > antoine.qu...@ensimag.grenoble-inp.fr wrote: >> Option parsing now uses the parser API instead of a local parser. >> Code is now more compact. >> Description for -stateless-rpc and --advertise-refs >> come from the commit (gmane/131517) > > Please, use a real commit id inst

Re: [PATCH v2] upload-pack.c: use of parse-options API

2016-05-19 Thread Matthieu Moy
antoine.qu...@ensimag.grenoble-inp.fr wrote: > Option parsing now uses the parser API instead of a local parser. > Code is now more compact. > Description for -stateless-rpc and --advertise-refs > come from the commit (gmane/131517) Please, use a real commit id instead of a Gmane link. We don't k

[PATCH v2] upload-pack.c: use of parse-options API

2016-05-19 Thread Antoine Queru
Option parsing now uses the parser API instead of a local parser. Code is now more compact. Description for -stateless-rpc and --advertise-refs come from the commit (gmane/131517) where there were implemented. Signed-off-by: Antoine Queru Signed-off-by: Matthieu Moy --- diff v1 v2: Usage displa