RE: [PATCH v2] upload-pack: Optionally allow fetching any sha1

2016-11-14 Thread David Turner
aturday, November 12, 2016 8:23 PM > To: David Turner > Cc: git@vger.kernel.org; spea...@spearce.org > Subject: Re: [PATCH v2] upload-pack: Optionally allow fetching any sha1 > > David Turner writes: > > > diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-s

Re: [PATCH v2] upload-pack: Optionally allow fetching any sha1

2016-11-12 Thread Junio C Hamano
David Turner writes: > diff --git a/t/t5551-http-fetch-smart.sh b/t/t5551-http-fetch-smart.sh > index 43665ab..8d3db40 100755 It seems that I haven't heard of 43665ab. > --- a/t/t5551-http-fetch-smart.sh > +++ b/t/t5551-http-fetch-smart.sh > @@ -306,6 +306,28 @@ test_expect_success 'test allowr

[PATCH v2] upload-pack: Optionally allow fetching any sha1

2016-11-11 Thread David Turner
It seems a little silly to do a reachabilty check in the case where we trust the user to access absolutely everything in the repository. Also, it's racy in a distributed system -- perhaps one server advertises a ref, but another has since had a force-push to that ref, and perhaps the two HTTP requ