Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-21 Thread Junio C Hamano
Johannes Löthberg writes: >>But if we made some change to the transfer to push-to-receive-pack >>so that this can also create HEAD that points at something, what >>would the user say, instead of that earlier >> >> $ git clone git://site.xz/r >> >>to access this new namespace? Don't you have to b

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Johannes Löthberg
On 20/06, Junio C Hamano wrote: Junio C Hamano writes: Let me step back and try again, as I think I am missing some existing feature you are using, and that missing piece is preventing me from seeing why this is a good idea (by the way, I do not think we are doing this exchange in the right thre

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Junio C Hamano
Junio C Hamano writes: >> You create a namespace by pushing to it,... > > You keep repeating that, but I do not think we agreed that it is the > supported or correct procedure to set up a new namespace in the > first place. Doesn't the server side need a lot more than just > setting up HEAD symr

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Johannes Löthberg
On 20/06, Junio C Hamano wrote: Johannes Löthberg writes: On 15/06, Junio C Hamano wrote: You would probably want new tests, but more importantly did you make sure this passes existing tests? It seems to break 5509 (there could be others) at least for me. It breaks 5509 currently yeah, th

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Junio C Hamano
Johannes Löthberg writes: > On 15/06, Junio C Hamano wrote: >>You would probably want new tests, but more importantly did you make >>sure this passes existing tests? It seems to break 5509 (there >>could be others) at least for me. >> > > It breaks 5509 currently yeah, though I've already fixed

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-20 Thread Johannes Löthberg
On 15/06, Junio C Hamano wrote: You would probably want new tests, but more importantly did you make sure this passes existing tests? It seems to break 5509 (there could be others) at least for me. It breaks 5509 currently yeah, though I've already fixed it locally. Anyway, You create a nam

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-15 Thread Junio C Hamano
Johannes Löthberg writes: > On 13/06, Johannes Löthberg wrote: >>Git should fail to clone if trying to clone from an non-existing >>ref namespace, since it's the same as a non-existing repository >> >>Signed-off-by: Johannes Löthberg >>--- >> >>Changes since v1: >> >>* Fixed the namespace check,

Re: [PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-12 Thread Johannes Löthberg
On 13/06, Johannes Löthberg wrote: Git should fail to clone if trying to clone from an non-existing ref namespace, since it's the same as a non-existing repository Signed-off-by: Johannes Löthberg --- Changes since v1: * Fixed the namespace check, since I apparently forgot to check with a ba

[PATCH v2] upload-pack: Fail if cloning empty namespace

2015-06-12 Thread Johannes Löthberg
Git should fail to clone if trying to clone from an non-existing ref namespace, since it's the same as a non-existing repository Signed-off-by: Johannes Löthberg --- Changes since v1: * Fixed the namespace check, since I apparently forgot to check with a bare repo in my last test. D'oh. Two