Re: [PATCH v2] submodule-config: use hashmap_iter_first()

2016-03-15 Thread Jeff King
to body. > > Either leave the body blank (as it is obvious) or write a whole sentence > there: > > [PATCH v2] submodule-config: use hashmap_iter_first() > > The hashmap API offers the `hashmap_iter_first` function as initializing and > getting the first entry is

Re: [PATCH v2] submodule-config: use hashmap_iter_first()

2016-03-15 Thread Eric Sunshine
ody. Yes, thanks for clarifying that. > Either leave the body blank (as it is obvious) or write a whole sentence > there: > > [PATCH v2] submodule-config: use hashmap_iter_first() > > The hashmap API offers the `hashmap_iter_first` function as initializing and > getting the

Re: [PATCH v2] submodule-config: use hashmap_iter_first()

2016-03-15 Thread Stefan Beller
TCH v2] submodule-config: use hashmap_iter_first() The hashmap API offers the `hashmap_iter_first` function as initializing and getting the first entry is a common pattern. Use that instead of doing initialization by hand and then get the first entry. > > Signed-off-by: Alexander

[PATCH v2] submodule-config: use hashmap_iter_first()

2016-03-15 Thread Alexander Kuleshov
from the for simplification. Signed-off-by: Alexander Kuleshov Reviewed-by: Stefan Beller --- Changelog: added missed Signof-off-by and function name fixed in the commit message. submodule-config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/submodule-config.c b/subm