> On 11 Sep 2017, at 05:27, Junio C Hamano wrote:
>
> Junio C Hamano writes:
>
>> I still think we would want to turn warning() to die(), but it
>> probably is better to do so in a separate follow-up patch. That
>> will give us a good place to record the reason why the current "just
>> call a
On 9/10/2017 11:27 PM, Junio C Hamano wrote:
Junio C Hamano writes:
I still think we would want to turn warning() to die(), but it
probably is better to do so in a separate follow-up patch. That
will give us a good place to record the reason why the current "just
call a warning() and preten
Junio C Hamano writes:
> I still think we would want to turn warning() to die(), but it
> probably is better to do so in a separate follow-up patch. That
> will give us a good place to record the reason why the current "just
> call a warning() and pretend as if nothing bad happend" is wrong.
An
Junio C Hamano writes:
> Ben Peart writes:
>
>>> - warning("external filter requested unsupported filter
>>> capability '%s'",
>>> - p);
>>> + warning("subprocess '%s' requested unsupported
>>> capability '%s'",
>>> +
Ben Peart writes:
>> -warning("external filter requested unsupported filter
>> capability '%s'",
>> -p);
>> +warning("subprocess '%s' requested unsupported
>> capability '%s'",
>> +process->argv[0],
> On 16 Aug 2017, at 14:40, Christian Couder wrote:
>
> In handshake_capabilities() we use warning() when a capability
> is not supported, so the exit code of the function is 0 and no
> further error is shown. This is a problem because the warning
> message doesn't tell us which subprocess cmd f
On 8/16/2017 8:40 AM, Christian Couder wrote:
In handshake_capabilities() we use warning() when a capability
is not supported, so the exit code of the function is 0 and no
further error is shown. This is a problem because the warning
message doesn't tell us which subprocess cmd failed.
On the
In handshake_capabilities() we use warning() when a capability
is not supported, so the exit code of the function is 0 and no
further error is shown. This is a problem because the warning
message doesn't tell us which subprocess cmd failed.
On the contrary if we cannot write a packet from this fun
8 matches
Mail list logo
