Re: [PATCH v2] server-info: do not list unlinked packs

2019-05-24 Thread Ævar Arnfjörð Bjarmason
On Thu, May 23 2019, Eric Wong wrote: > Jeff King wrote: >> On Thu, May 23, 2019 at 08:59:59AM +, Eric Wong wrote: >> >> > > We never delete entries from the in-memory packed_git list; a reprepare >> > > only adds to the list. You'd need to teach update_server_info() to >> > > ignore packs

Re: [PATCH v2] server-info: do not list unlinked packs

2019-05-23 Thread Jeff King
On Thu, May 23, 2019 at 05:27:23PM +, Eric Wong wrote: > ALLOC_GROW makes the whole thing much nicer. > Thanks for the hint :> > > -8<- > Subject: [PATCH] server-info: do not list unlinked packs This looks fine to me (though the "v2" note is in your co

[PATCH v2] server-info: do not list unlinked packs

2019-05-23 Thread Eric Wong
Jeff King wrote: > On Thu, May 23, 2019 at 08:59:59AM +, Eric Wong wrote: > > > > We never delete entries from the in-memory packed_git list; a reprepare > > > only adds to the list. You'd need to teach update_server_info() to > > > ignore packs which are no longer present (or switch to exec-