Re: [PATCH v2] sequencer.c: fix and unify error messages in rearrange_squash()

2017-10-16 Thread Junio C Hamano
"Philip Oakley" writes: > Hi, 'Truncate' is real English, but it is not that common in normal usage. > > My dictionary suggests that it means 'cut off at the tip' such as a > truncated cone. However the thesaurus is far more relaxed about the > common idioms that truncate at the tail such as: cli

Re: [PATCH v2] sequencer.c: fix and unify error messages in rearrange_squash()

2017-10-16 Thread Philip Oakley
From: "Johannes Schindelin" On Mon, 16 Oct 2017, Junio C Hamano wrote: Ralf Thielow writes: > When the write opertion fails, we write that we could > not read. Change the error message to match the operation > and remove the full stop at the end. > > When ftruncate() fails, we write that we

Re: [PATCH v2] sequencer.c: fix and unify error messages in rearrange_squash()

2017-10-16 Thread Johannes Schindelin
Hi Junio, On Mon, 16 Oct 2017, Junio C Hamano wrote: > Ralf Thielow writes: > > > When the write opertion fails, we write that we could > > not read. Change the error message to match the operation > > and remove the full stop at the end. > > > > When ftruncate() fails, we write that we couldn'

Re: [PATCH v2] sequencer.c: fix and unify error messages in rearrange_squash()

2017-10-15 Thread Junio C Hamano
Ralf Thielow writes: > When the write opertion fails, we write that we could > not read. Change the error message to match the operation > and remove the full stop at the end. > > When ftruncate() fails, we write that we couldn't finish > the operation on the todo file. It is more accurate to wri

[PATCH v2] sequencer.c: fix and unify error messages in rearrange_squash()

2017-10-15 Thread Ralf Thielow
When the write opertion fails, we write that we could not read. Change the error message to match the operation and remove the full stop at the end. When ftruncate() fails, we write that we couldn't finish the operation on the todo file. It is more accurate to write that we couldn't truncate as we