Re: [PATCH v2] send-email: die if CA path doesn't exist

2015-11-25 Thread Jeff King
On Wed, Nov 25, 2015 at 10:19:09AM +, John Keeping wrote: > > > Changes since v1: > > > - add missing path to error message > > > - remove trailing '.' on error message since die appends "at > > > /path/to/git-send-email line ..." > > > > It won't if the error message ends with a newline. W

Re: [PATCH v2] send-email: die if CA path doesn't exist

2015-11-25 Thread John Keeping
On Tue, Nov 24, 2015 at 06:35:36PM -0500, Jeff King wrote: > On Tue, Nov 24, 2015 at 11:31:40PM +, John Keeping wrote: > > > If the CA path isn't found it's most likely to indicate a > > misconfiguration, in which case accepting any certificate is unlikely to > > be the correct thing to do. >

Re: [PATCH v2] send-email: die if CA path doesn't exist

2015-11-24 Thread Jeff King
On Tue, Nov 24, 2015 at 11:31:40PM +, John Keeping wrote: > If the CA path isn't found it's most likely to indicate a > misconfiguration, in which case accepting any certificate is unlikely to > be the correct thing to do. Thanks. > Changes since v1: > - add missing path to error message > -

[PATCH v2] send-email: die if CA path doesn't exist

2015-11-24 Thread John Keeping
If the CA path isn't found it's most likely to indicate a misconfiguration, in which case accepting any certificate is unlikely to be the correct thing to do. Signed-off-by: John Keeping --- Changes since v1: - add missing path to error message - remove trailing '.' on error message since die app