Re: [PATCH v2] run-command: report exec failure

2018-12-13 Thread Johannes Schindelin
Hi Junio, On Thu, 13 Dec 2018, Junio C Hamano wrote: >I am taking that https://travis-ci.org/git/git/jobs/466908193 >that succeeded on Windows as a sign that this is now OK there. I concur, Dscho

Re: [PATCH v2] run-command: report exec failure

2018-12-13 Thread Junio C Hamano
Jeff King writes: > On Thu, Dec 13, 2018 at 03:36:53AM +0900, Junio C Hamano wrote: > >> test_expect_success 'start_command reports ENOENT (slash)' ' >> -test-tool run-command start-command-ENOENT ./does-not-exist >> +test-tool run-command start-command-ENOENT ./does-not-exist 2>err && >

Re: [PATCH v2] run-command: report exec failure

2018-12-13 Thread Jeff King
On Thu, Dec 13, 2018 at 03:36:53AM +0900, Junio C Hamano wrote: > In 321fd823 ("run-command: mark path lookup errors with ENOENT", > 2018-10-24), we rewrote the logic to execute a command by looking > in the directories on $PATH; as a side effect, a request to run a > command that is not found on

[PATCH v2] run-command: report exec failure

2018-12-12 Thread Junio C Hamano
In 321fd823 ("run-command: mark path lookup errors with ENOENT", 2018-10-24), we rewrote the logic to execute a command by looking in the directories on $PATH; as a side effect, a request to run a command that is not found on $PATH is noticed even before a child process is forked to execute it. We