Re: [PATCH v2] replace --edit: respect core.editor

2016-04-20 Thread Junio C Hamano
Jeff King writes: > On Wed, Apr 20, 2016 at 08:38:03AM +0200, Johannes Schindelin wrote: > >> We simply need to read the config, is all. >> >> This fixes https://github.com/git-for-windows/git/issues/733 >> >> Signed-off-by: Johannes Schindelin > > Looks good to me. Thanks. Yup, I think the n

Re: [PATCH v2] replace --edit: respect core.editor

2016-04-19 Thread Jeff King
On Wed, Apr 20, 2016 at 08:38:03AM +0200, Johannes Schindelin wrote: > We simply need to read the config, is all. > > This fixes https://github.com/git-for-windows/git/issues/733 > > Signed-off-by: Johannes Schindelin Looks good to me. Thanks. -Peff -- To unsubscribe from this list: send the

[PATCH v2] replace --edit: respect core.editor

2016-04-19 Thread Johannes Schindelin
We simply need to read the config, is all. This fixes https://github.com/git-for-windows/git/issues/733 Signed-off-by: Johannes Schindelin --- builtin/replace.c | 1 + 1 file changed, 1 insertion(+) Interdiff vs v1: diff --git a/builtin/replace.c b/builtin/replace.c index 02b13f6..b58c714 10