Re: [PATCH v2] rebase: add --allow-empty-message option

2018-02-07 Thread Junio C Hamano
Johannes Schindelin writes: > Very nice. I looked over the patch (sorry, I have too little time to test > this thoroughly, but then, it is the custom on this here mailing list to > just review the patch as per the mail) and it looks very good to me. > > Junio, if you like, please add a "Reviewed-

Re: [PATCH v2] rebase: add --allow-empty-message option

2018-02-06 Thread Johannes Schindelin
Hi Genki, On Sun, 4 Feb 2018, Genki Sky wrote: > This option allows commits with empty commit messages to be rebased, > matching the same option in git-commit and git-cherry-pick. While empty > log messages are frowned upon, sometimes one finds them in older > repositories (e.g. translated from a

[PATCH v2] rebase: add --allow-empty-message option

2018-02-04 Thread Genki Sky
This option allows commits with empty commit messages to be rebased, matching the same option in git-commit and git-cherry-pick. While empty log messages are frowned upon, sometimes one finds them in older repositories (e.g. translated from another VCS [0]), or have other reasons for desiring them.