Re: [PATCH v2] promisor-remote: skip move_to_tail when no-op

2019-09-26 Thread Jeff King
On Thu, Sep 26, 2019 at 02:31:56PM -0700, Emily Shaffer wrote: > --- > Thanks Peff for pointing out this bug occurs any time the tail is being > moved to tail in the promisors list. Modified patch to check just for > "already at tail" condition. > > Added a test case based on Peff's reproduction

[PATCH v2] promisor-remote: skip move_to_tail when no-op

2019-09-26 Thread Emily Shaffer
Previously, when promisor_remote_move_to_tail() is called for a promisor_remote which is currently the final element in promisors, a cycle is created in the promisors linked list. This cycle leads to a double free later on in promisor_remote_clear() when the final element of the promisors list is r