Re: [PATCH v2] mailinfo.c: move side-effects outside of assert

"Kyle J. McKay" writes: >> OK. So we do not expect it to fail, but we still do want the side >> effect of that function (i.e. accmulation into the field). >> >> Somebody care to send a final "agreed-upon" version? > > Yup, here it is: Thanks. > -- 8< -- > > Since 6b4b013f18 (mailinfo: handle i

[PATCH v2] mailinfo.c: move side-effects outside of assert

On Dec 19, 2016, at 13:01, Junio C Hamano wrote: > Jonathan Tan writes: > This is obviously an improvement, but it makes me wonder if we should be doing: if (!check_header(mi, &mi->inbody_header_accum, mi->s_hdr_data)) die("BUG: some explanation of why this can