Re: [PATCH v2] gitweb: apply fallback encoding before highlight

2016-05-05 Thread Shin Kojima
> Oh, don't get me wrong. I do think what the patch does is very > sensible and have no intention of rejecting it. I'm sorry for making you worry, my poor English had caused some misunderstanding. I raised this Shift_JIS related problem (a.k.a "ダメ文字" in Japanese) might attract your interest knowi

Re: [PATCH v2] gitweb: apply fallback encoding before highlight

2016-05-04 Thread Junio C Hamano
Shin Kojima writes: > I can say this patch, to consider $fallback_encoding while > highlighting, is fairly rational. But I also feel this is too much > just for specific outdated character encodings, it is completely > useless for the most part of gitweb users in the world. Oh, don't get me wro

Re: [PATCH v2] gitweb: apply fallback encoding before highlight

2016-05-04 Thread Shin Kojima
On Tue, May 03, 2016 at 11:33:42AM -0700, Junio C Hamano wrote: > Shin Kojima writes: > > > Some multi-byte character encodings (such as Shift_JIS and GBK) have > > characters whose final bytes is an ASCII '\' (0x5c), and they > > will be displayed as funny-characters even if $fallback_encoding i

Re: [PATCH v2] gitweb: apply fallback encoding before highlight

2016-05-03 Thread Junio C Hamano
Shin Kojima writes: > Some multi-byte character encodings (such as Shift_JIS and GBK) have > characters whose final bytes is an ASCII '\' (0x5c), and they > will be displayed as funny-characters even if $fallback_encoding is > correct. Just out of curiosity, do people still use Shift_JIS aka MS-

[PATCH v2] gitweb: apply fallback encoding before highlight

2016-05-03 Thread Shin Kojima
Some multi-byte character encodings (such as Shift_JIS and GBK) have characters whose final bytes is an ASCII '\' (0x5c), and they will be displayed as funny-characters even if $fallback_encoding is correct. This is because `highlight` command always expects UTF-8 encoded strings from STDIN.