Re: [PATCH v2] git{,-blame}.el: remove old bitrotting Emacs code

2018-03-13 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > I sent a v3 a few days ago which addressed this, it's at > 20180310184545.16950-1-ava...@gmail.com Thanks, I did look at that version but did not act on it immediately and then forgot about it. Queued.

Re: [PATCH v2] git{,-blame}.el: remove old bitrotting Emacs code

2018-03-13 Thread Ævar Arnfjörð Bjarmason
On Tue, Mar 13 2018, Junio C. Hamano jotted: > Martin Ågren writes: > >>> +Emacs's own support for Git got better than what was offered by these >>> +modules, or was superseded by popular 3rd-party Git modes such as >>> +Magit. >> >> This somehow reads like "Emacs's own support ... was supersede

Re: [PATCH v2] git{,-blame}.el: remove old bitrotting Emacs code

2018-03-13 Thread Junio C Hamano
Martin Ågren writes: >> +Emacs's own support for Git got better than what was offered by these >> +modules, or was superseded by popular 3rd-party Git modes such as >> +Magit. > > This somehow reads like "Emacs's own support ... was superseded ...". > Maybe that's what you mean, but i'm not sure.

Re: [PATCH v2] git{,-blame}.el: remove old bitrotting Emacs code

2018-03-10 Thread Martin Ågren
On 10 March 2018 at 13:30, Ævar Arnfjörð Bjarmason wrote: > diff --git a/contrib/emacs/README b/contrib/emacs/README > index 82368bdbff..5a63109458 100644 > --- a/contrib/emacs/README > +++ b/contrib/emacs/README > @@ -1,30 +1,24 @@ > -This directory contains various modules for Emacs support. > +

[PATCH v2] git{,-blame}.el: remove old bitrotting Emacs code

2018-03-10 Thread Ævar Arnfjörð Bjarmason
The git-blame.el mode has been superseded by Emacs's own vc-annotate (invoked by C-x v g). Users of the git.el mode are now much better off using either Magit or the Git backend for Emacs's own VC mode. These modes were added over 10 years ago when Emacs's own Git support was much less mature, and