Re: [PATCH v2] fetch-pack: clear alternate shallow when complete

2019-02-06 Thread brian m. carlson
On Wed, Feb 06, 2019 at 06:53:50PM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > >> The patch looks good to me. > > > > Thanks, all. > > Oops, spoke a bit too fast. As the previous one is already in > 'next', let's do this instead. That's fine with me. Sorry about the delay getting

Re: [PATCH v2] fetch-pack: clear alternate shallow when complete

2019-02-06 Thread Junio C Hamano
Junio C Hamano writes: >> The patch looks good to me. > > Thanks, all. Oops, spoke a bit too fast. As the previous one is already in 'next', let's do this instead. -- >8 -- From: "brian m. carlson" Date: Wed, 6 Feb 2019 23:59:37 + Subject: [PATCH] fetch-pack: clear alternate shallow in on

Re: [PATCH v2] fetch-pack: clear alternate shallow when complete

2019-02-06 Thread Junio C Hamano
Duy Nguyen writes: > On Thu, Feb 7, 2019 at 7:00 AM brian m. carlson > wrote: >> >> When we write an alternate shallow file in update_shallow, we write it >> into the lock file. The string stored in alternate_shallow_file is >> copied from the lock file path, but it is freed the moment that the

Re: [PATCH v2] fetch-pack: clear alternate shallow when complete

2019-02-06 Thread Duy Nguyen
On Thu, Feb 7, 2019 at 7:00 AM brian m. carlson wrote: > > When we write an alternate shallow file in update_shallow, we write it > into the lock file. The string stored in alternate_shallow_file is > copied from the lock file path, but it is freed the moment that the lock > file is closed, since

[PATCH v2] fetch-pack: clear alternate shallow when complete

2019-02-06 Thread brian m. carlson
When we write an alternate shallow file in update_shallow, we write it into the lock file. The string stored in alternate_shallow_file is copied from the lock file path, but it is freed the moment that the lock file is closed, since we call strbuf_release to free that path. This used to work, sinc