Re: [PATCH v2] fast-import: implement unpack limit

2016-04-24 Thread Eric Wong
Junio C Hamano wrote: > Eric Wong writes: > > + argv_array_push(&unpack.args, "unpack-objects"); > > + argv_array_push(&unpack.args, "-q"); > > + > > + return run_command(&unpack); > Looks good. I haven't thought if "-q" is appropriate or not though. Oops, I think tying it to the existi

Re: [PATCH v2] fast-import: implement unpack limit

2016-04-24 Thread Junio C Hamano
Eric Wong writes: > +static int loosen_small_pack(const struct packed_git *p) > +{ > + struct child_process unpack = CHILD_PROCESS_INIT; > + > + if (lseek(p->pack_fd, 0, SEEK_SET) < 0) > + die_errno("Failed seeking to start of '%s'", p->pack_name); > + > + unpack.in = p->p

[PATCH v2] fast-import: implement unpack limit

2016-04-23 Thread Eric Wong
Jeff King wrote: > There we have fetch.unpackLimit and receive.unpackLimit for the two > operations, plus transfer.unpackLimit to control both of them. This > doesn't necessarily need to be tied to that config, but you could > certainly consider it in the same boat. It's a way of transferring a >