Re: [PATCH v2] diff: fix --relative without arguments

2017-12-07 Thread Jacob Keller
On Thu, Dec 7, 2017 at 7:26 AM, Junio C Hamano wrote: > Jacob Keller writes: > >> From: Jacob Keller >> >> Recently, commit f7923a5ece00 ("diff: use skip_to_optional_val()", >> 2017-12-04) changed how we parsed some diff options, preferring >> skip_to_optional_val instead of a more complex skip_

Re: [PATCH v2] diff: fix --relative without arguments

2017-12-07 Thread Junio C Hamano
Jacob Keller writes: > From: Jacob Keller > > Recently, commit f7923a5ece00 ("diff: use skip_to_optional_val()", > 2017-12-04) changed how we parsed some diff options, preferring > skip_to_optional_val instead of a more complex skip_prefix() setup. I'd expect a moral equivalent of this squashed

[PATCH v2] diff: fix --relative without arguments

2017-12-06 Thread Jacob Keller
From: Jacob Keller Recently, commit f7923a5ece00 ("diff: use skip_to_optional_val()", 2017-12-04) changed how we parsed some diff options, preferring skip_to_optional_val instead of a more complex skip_prefix() setup. Unfortunately, this breaks --relative, because of the semantics of skip_to_opt