Re: [PATCH v2] diff: ensure correct lifetime of external_diff_cmd

2019-01-11 Thread Junio C Hamano
Kim Gybels writes: > According to getenv(3)'s notes: > > The implementation of getenv() is not required to be reentrant. The > string pointed to by the return value of getenv() may be statically > allocated, and can be modified by a subsequent call to getenv(), > putenv(3), seten

[PATCH v2] diff: ensure correct lifetime of external_diff_cmd

2019-01-11 Thread Kim Gybels
According to getenv(3)'s notes: The implementation of getenv() is not required to be reentrant. The string pointed to by the return value of getenv() may be statically allocated, and can be modified by a subsequent call to getenv(), putenv(3), setenv(3), or unsetenv(3). Since str