Re: [PATCH v2] diff: don't attempt to strip prefix from absolute Windows paths

2018-10-19 Thread Stefan Beller
> +test_expect_success 'diff --no-index from repo subdir with absolute paths' ' I was late looking at the test, and was about to propose to guard it to run only on Windows (as this test seems of little use in other OS), but after thinking about it I think we should keep it as-is, as there may be o

[PATCH v2] diff: don't attempt to strip prefix from absolute Windows paths

2018-10-19 Thread Johannes Sixt
git diff can be invoked with absolute paths. Typically, this triggers the --no-index case. Then the absolute paths remain in the file names that are printed in the output. There is one peculiarity, though: When the command is invoked from a a sub-directory in a repository, then it is attempted to