Re: [PATCH v2] diff: disable compaction heuristic for now

2016-06-10 Thread Junio C Hamano
Jeff King writes: > Looks good. > > I think your calendar calls for release 2.9.0 on Monday. Are you going > to bump the schedule for this? I don't think it's very high risk, and > wouldn't need to. I didn't plan to. -- To unsubscribe from this list: send the line "unsubscribe git" in the body o

Re: [PATCH v2] diff: disable compaction heuristic for now

2016-06-10 Thread Jeff King
On Fri, Jun 10, 2016 at 01:55:01PM -0700, Junio C Hamano wrote: > This is for 'master' when the topic is merged (will keep it in stash > for now). > > Documentation/RelNotes/2.9.0.txt | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/Documentation/RelNotes/2.9.0.t

Re: [PATCH v2] diff: disable compaction heuristic for now

2016-06-10 Thread Junio C Hamano
Junio C Hamano writes: > Jeff King writes: > > > We probably want a patch to the release notes to note that it's not on > > by default. And we may want to advertise the experimental knob so > > that people actually try it (otherwise we won't get feedback from the > > masses).

Re: [PATCH v2] diff: disable compaction heuristic for now

2016-06-10 Thread Jeff King
On Fri, Jun 10, 2016 at 01:48:58PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > We probably want a patch to the release notes to note that it's not on > > by default. And we may want to advertise the experimental knob so > > that people actually try it (otherwise we won

[PATCH v2] diff: disable compaction heuristic for now

2016-06-10 Thread Junio C Hamano
http://lkml.kernel.org/g/20160610075043.ga13...@sigill.intra.peff.net reports that a change to add a new "function" with common ending with the existing one at the end of the file is shown like this: def foo do_foo_stuff() + common_ending() +end + +def bar + do_bar_stuf