Re: [PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-19 Thread Jeff King
On Fri, Jan 19, 2018 at 01:20:41PM -0800, Junio C Hamano wrote: > > Documentation/merge-config.txt | 4 ++ > > builtin/merge.c| 2 + > > A+x t/t5573-pull-verify-signatures.sh | 81 > > t/t7612-merge-verify-signatures.sh | 45

Re: [PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-19 Thread Jeff King
On Fri, Jan 19, 2018 at 07:26:28AM +0700, Duy Nguyen wrote: > > (I know this is a bikeshed, so I'm perfectly willing to take "yuck, I > > don't like that as well" as a response). > > The position of A+x column is exactly where gerrit put it. Though web > pages have more flexibility than our termi

Re: [PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-19 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy writes: > Documentation/merge-config.txt | 4 + > builtin/merge.c| 2 + >A t/t5573-pull-verify-signatures.sh | 81 ++ > t/t7612-merge-verify-signatures.sh | 45 ++ >4 files changed, 132 insertions(+) > ...

Re: [PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-18 Thread Duy Nguyen
On Fri, Jan 19, 2018 at 5:48 AM, Jeff King wrote: > On Thu, Jan 18, 2018 at 05:05:46PM +0700, Nguyễn Thái Ngọc Duy wrote: > >> This is partly inspired by gerrit web interface which shows diffstat >> like this, e.g. with commit 0433d533f1 (notice the "A" column on the >> third line): >> >> Doc

Re: [PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-18 Thread Duy Nguyen
On Fri, Jan 19, 2018 at 4:23 AM, Ævar Arnfjörð Bjarmason wrote: > Wait, isn't there a bug here in the existing --summary code, its > documentation says it'll show information "such as creations, renames > and mode changes". > > But even though your --compact-summary shows that the file is being >

Re: [PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-18 Thread Duy Nguyen
On Fri, Jan 19, 2018 at 1:57 AM, Eric Sunshine wrote: >> diff --git a/Documentation/diff-options.txt b/Documentation/diff-options.txt >> @@ -188,6 +188,17 @@ and accumulating child directory counts in the parent >> directories: >> +--compact-summary:: >> + Output a condensed summary of exte

Re: [PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-18 Thread Jeff King
On Thu, Jan 18, 2018 at 05:05:46PM +0700, Nguyễn Thái Ngọc Duy wrote: > This is partly inspired by gerrit web interface which shows diffstat > like this, e.g. with commit 0433d533f1 (notice the "A" column on the > third line): > > Documentation/merge-config.txt | 4 + > builtin/merg

Re: [PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-18 Thread Ævar Arnfjörð Bjarmason
On Thu, Jan 18 2018, Nguyễn Thái Ngọc Duy jotted: > This is partly inspired by gerrit web interface which shows diffstat > like this, e.g. with commit 0433d533f1 (notice the "A" column on the > third line): > > > Documentation/merge-config.txt | 4 + > builtin/merge.c

Re: [PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-18 Thread Eric Sunshine
On Thu, Jan 18, 2018 at 5:05 AM, Nguyễn Thái Ngọc Duy wrote: > [...] > The new option --compact-summary implements this with a tweak to support > mode change, which is shown in --summary too. > > For mode changes, executable bit is denoted as "M+x" or "M-x" when it's > added or removed respectivel

[PATCH v2] diff: add --compact-summary option to complement --stat

2018-01-18 Thread Nguyễn Thái Ngọc Duy
This is partly inspired by gerrit web interface which shows diffstat like this, e.g. with commit 0433d533f1 (notice the "A" column on the third line): Documentation/merge-config.txt | 4 + builtin/merge.c| 2 + A t/t5573-pull-verify-signatures.sh | 81