Re: [PATCH v2] credential-osxkeychain: support more protocols

2013-05-27 Thread Jeff King
On Mon, May 27, 2013 at 11:46:24PM +0800, Xidorn Quan wrote: > > We may also eventually want IMAP for git-imap-send, but we have not yet > > implemented credential-helper support there. We may also want http/socks > > proxy authentication, but we also have not implemented the git side of > > that

Re: [PATCH v2] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
On Mon, May 27, 2013 at 11:08 PM, Jeff King wrote: [snip] > > This looks good to me. Git will ask for "protocol=ftp" when > accessing the dumb protocol over ftp. And it will ask for smtp via > git-send-email since 4d31a44 (git-send-email: use git credential to > obtain password, 2013-02-12). > > W

Re: [PATCH v2] credential-osxkeychain: support more protocols

2013-05-27 Thread Jeff King
On Mon, May 27, 2013 at 10:35:59PM +0800, Xidorn Quan wrote: > diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c > b/contrib/credential/osxkeychain/git-credential-osxkeychain.c > index 3940202..648fadd 100644 > --- a/contrib/credential/osxkeychain/git-credential-osxkeychain

[PATCH v2] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
Add protocol ftp and smtp for credential-osxkeychain. Acked-by: John Szakmeister Signed-off-by: Xidorn Quan --- contrib/credential/osxkeychain/git-credential-osxkeychain.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/credential/osxkeychain/git-credential-osx