Re: [PATCH v2] convert log_ref_write_fd() to use strbuf

On Tue, Jul 10, 2018 at 09:08:22PM +, Ben Peart wrote: > Since we don't care about how many bytes were written, simplify the return > value logic. > > log_ref_write_fd() was written long before strbuf was fleshed out. Remove > the old manual buffer management code and replace it with strbuf().

Re: [PATCH v2] convert log_ref_write_fd() to use strbuf

Ben Peart writes: > diff --git a/refs/files-backend.c b/refs/files-backend.c > index a9a066dcfb..054306d779 100644 > --- a/refs/files-backend.c > +++ b/refs/files-backend.c > @@ -1582,26 +1582,17 @@ static int log_ref_write_fd(int fd, const struct > object_id *old_oid, >

[PATCH v2] convert log_ref_write_fd() to use strbuf

Since we don't care about how many bytes were written, simplify the return value logic. log_ref_write_fd() was written long before strbuf was fleshed out. Remove the old manual buffer management code and replace it with strbuf(). Also update copy_reflog_msg() which is called only by log_ref_write_