On Sun, May 25, 2014 at 2:24 AM, Caleb Thompson wrote:
> Incorporated changes from Duy Nguyen and Jeremiah Mahler.
As a courtesy to reviewers, it is helpful to provide a pointer to the
previous submission to give context for the new submission. For
instance, like this [1].
[1]:
http://git.66134
On Sun, May 25, 2014 at 1:24 PM, Caleb Thompson wrote:
> Duy, you were right about `-V`. Do you know of a simple way to add that
> shortened flag? `OPT_BOOL('v', "verbose", ...)` gives me `-v`, `--verbose`,
> and
> `--no-verbose`, but no `-V` as a shortened form of `--no-verbose`.
No, I don't th
On Sun, May 25, 2014 at 01:24:27AM -0500, Caleb Thompson wrote:
> Incorporated changes from Duy Nguyen and Jeremiah Mahler.
>
...
>
> +test_expect_success 'commit shows verbose diff with set commit.verbose' '
> + echo morecontent >file &&
> + git add file &&
> + test_config commit.ver
On Sun, May 25, 2014 at 01:24:27AM -0500, Caleb Thompson wrote:
...
> would be committed at the bottom of the commit message
> template. Note that this diff output doesn't have its
> - lines prefixed with '#'.
> + lines prefixed with '#'. The `commit.verbose` configuration
> +
Incorporated changes from Duy Nguyen and Jeremiah Mahler.
Jeremiah, I didn't make the changes about `<<-EOF` or `test_expect_success`
because I'm guessing that keeping the local style of the code intact is more
important than using those. Do you think it makes sense to refactor the rest of
the tes
5 matches
Mail list logo
