Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-02 Thread Sidhant Sharma
> On Wed, Mar 2, 2016 at 3:21 AM, Sidhant Sharma [:tk] > wrote: >> + struct option options[] = { >> + OPT__QUIET(&quiet, N_("quiet")), >> + OPT_HIDDEN_BOOL(0, "stateless-rpc", &stateless_rpc, NULL), >> + OPT_HIDDEN_BOOL(0, "advertise-refs", &adverti

Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-02 Thread Duy Nguyen
On Wed, Mar 2, 2016 at 3:21 AM, Sidhant Sharma [:tk] wrote: > + struct option options[] = { > + OPT__QUIET(&quiet, N_("quiet")), > + OPT_HIDDEN_BOOL(0, "stateless-rpc", &stateless_rpc, NULL), > + OPT_HIDDEN_BOOL(0, "advertise-refs", &advertise_refs,

Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-02 Thread Junio C Hamano
Sidhant Sharma writes: >> Matthieu Moy writes: >> >>> Thanks. This version looks good to me. >> I'll queue this with your "Reviewed-by:" to 'pu', just as a >> Microproject reward ;-). Given that the program will never see an >> interactive use from a command line, however, I am not sure if it i

Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-02 Thread Matthieu Moy
Junio C Hamano writes: > Matthieu Moy writes: > >> "Sidhant Sharma [:tk]" writes: >> >>> Make receive-pack use the parse_options API, >>> bringing it more in line with send-pack and push. >> >> Thanks. This version looks good to me. > > I'll queue this with your "Reviewed-by:" to 'pu', just as

Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Sidhant Sharma
> Matthieu Moy writes: > >> "Sidhant Sharma [:tk]" writes: >> >>> Make receive-pack use the parse_options API, >>> bringing it more in line with send-pack and push. >> Thanks. This version looks good to me. > I'll queue this with your "Reviewed-by:" to 'pu', just as a > Microproject reward ;-).

Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Junio C Hamano
Matthieu Moy writes: > "Sidhant Sharma [:tk]" writes: > >> Make receive-pack use the parse_options API, >> bringing it more in line with send-pack and push. > > Thanks. This version looks good to me. I'll queue this with your "Reviewed-by:" to 'pu', just as a Microproject reward ;-). Given tha

Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Matthieu Moy
"Sidhant Sharma [:tk]" writes: > Make receive-pack use the parse_options API, > bringing it more in line with send-pack and push. Thanks. This version looks good to me. -- Matthieu Moy http://www-verimag.imag.fr/~moy/ -- To unsubscribe from this list: send the line "unsubscribe git" in the bod

Re: [PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Sidhant Sharma
> Starting from here, the patch is a bit painful to read because the diff > heuristics grouped hunks in a strange way. You may try "git format-patch > --patience" or --minimal or --histogram to see if it gives a better > result. The final commit would be the same, but it may make review > easier.

[PATCH v2] builtin/receive-pack.c: use parse_options API

2016-03-01 Thread Sidhant Sharma [:tk]
Make receive-pack use the parse_options API, bringing it more in line with send-pack and push. Helped-by: Matthieu Moy Signed-off-by: Sidhant Sharma [:tk] --- Link to previous version: $gmane/288035 builtin/receive-pack.c | 53 +++--- 1 file change