Re: [PATCH v2] add a flag to supress errors in git_config_parse_key()

2015-02-18 Thread Jeff King
On Mon, Feb 16, 2015 at 01:28:07PM +0530, Tanay Abhra wrote: > I went through Junio's config guideline patch series > and the whole thread of underscore bug report and I also think > that pager.*.command is the right path to go. > > If you want to relax the syntactic requirement (such as add '_'

[PATCH v2] add a flag to supress errors in git_config_parse_key()

2015-02-16 Thread Tanay Abhra
`git_config_parse_key()` is used to sanitize the input key. Some callers of the function like `git_config_set_multivar_in_file()` get the pre-sanitized key directly from the user so it becomes necessary to raise an error specifying what went wrong when the entered key is syntactically malformed.