Re: [PATCH v2] Make the global packed_git variable static to sha1_file.c.

I uploaded a new patch; a few comments inline below... On Wed, Feb 12, 2014 at 1:19 PM, Junio C Hamano wrote: > sza...@chromium.org writes: > > Also I'd suggest s/pack_data_fn/collect_pack_data/ or something. > "_fn" may be a good suffix for typedef'ed typename used in a > callback function, but

Re: [PATCH v2] Make the global packed_git variable static to sha1_file.c.

sza...@chromium.org writes: > From 0a59547f3e95ddecf7606c5f259ae6177c5a104f Mon Sep 17 00:00:00 2001 Please drop this line. > From: Stefan Zager Please drop this line and instead have it in your e-mail header. > Date: Mon, 10 Feb 2014 16:55:12 -0800 The date in your e-mail header, which is t

Re: [PATCH v2] Make the global packed_git variable static to sha1_file.c.

I'll locally fix up these style issues before commenting on the patch. Thanks. ERROR: space required after that ',' (ctx:VxV) #78: FILE: builtin/count-objects.c:111: + struct pack_data pd = {0,0,0}; ^ ERROR: space required after that ',' (ctx:VxV) #78: FILE:

[PATCH v2] Make the global packed_git variable static to sha1_file.c.

>From 0a59547f3e95ddecf7606c5f259ae6177c5a104f Mon Sep 17 00:00:00 2001 From: Stefan Zager Date: Mon, 10 Feb 2014 16:55:12 -0800 Subject: [PATCH] Make the global packed_git variable static to sha1_file.c. This is a first step in making the codebase thread-safe. By and large, the operations which