Re: [PATCH v2/RFC] commit: change the meaning of an empty commit message

2017-10-02 Thread Kaartic Sivaraam
On Thu, 2017-08-31 at 19:06 +0530, Kaartic Sivaraam wrote: > On Thu, 2017-08-24 at 13:19 -0700, Junio C Hamano wrote: > > > > The latter is easier for me as we do not have to worry about > > breaking people's scripts and tools used in > > their established workflows at all. > > > > In that case

Re: [PATCH v2/RFC] commit: change the meaning of an empty commit message

2017-08-31 Thread Kaartic Sivaraam
On Thu, 2017-08-24 at 13:19 -0700, Junio C Hamano wrote: > > The latter is easier for me as we do not have to worry about > breaking people's scripts and tools used in > their established workflows at all. > In that case, how about doing something similar to what was done to 'set-upstream' opti

Re: [PATCH v2/RFC] commit: change the meaning of an empty commit message

2017-08-24 Thread Junio C Hamano
Kaartic Sivaraam writes: > As has been noted by Junio, > > "It would be a backward incompatible tightening of the established > rule, but it may not be a bad change." > > The "It" above refers to this change. Expecting comments from people to > ensure > this change isn't a bad one.

[PATCH v2/RFC] commit: change the meaning of an empty commit message

2017-08-21 Thread Kaartic Sivaraam
An "empty commit message" according to 'commit' has long been, A message that contains only empty lines and/or whitespaces and/or 'Signed-off-by' lines This is biased as a commit message that contains only other trailers like 'Helped-by: ', 'Tested-by: ' etc., could equally be considered