Re: [PATCH v14 6/6] commit: add a commit.verbose config variable

2016-04-13 Thread Eric Sunshine
On Wed, Apr 13, 2016 at 5:15 AM, Pranit Bauva wrote: > On Wed, Apr 13, 2016 at 11:44 AM, Eric Sunshine > wrote: >> On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva wrote: >>> +test_expect_success 'status does not verbose without --verbose' ' >>> + git status >actual && >>> + ! grep "^d

Re: [PATCH v14 6/6] commit: add a commit.verbose config variable

2016-04-13 Thread Pranit Bauva
On Wed, Apr 13, 2016 at 11:44 AM, Eric Sunshine wrote: > On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva wrote: > >> +test_expect_success 'status does not verbose without --verbose' ' >> + git status >actual && >> + ! grep "^diff --git" actual >> +' > > But what is this test checking?

Re: [PATCH v14 6/6] commit: add a commit.verbose config variable

2016-04-12 Thread Eric Sunshine
On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva wrote: > Add commit.verbose configuration variable as a convenience for those > who always prefer --verbose. > > Helped-by: Junio C Hamano > Helped-by: Eric Sunshine > Signed-off-by: Pranit Bauva > --- > diff --git a/t/t7507-commit-verbose.sh b/t/t7

[PATCH v14 6/6] commit: add a commit.verbose config variable

2016-04-12 Thread Pranit Bauva
Add commit.verbose configuration variable as a convenience for those who always prefer --verbose. Helped-by: Junio C Hamano Helped-by: Eric Sunshine Signed-off-by: Pranit Bauva --- The previous version of the patch are: - [v12] $gmane/288820 - [v11] $gmane/288820 - [v10] $gmane/288820 - [v