Re: [PATCH v14 3/6] t0040-parse-options: improve test coverage

2016-04-27 Thread Pranit Bauva
On Wed, Apr 27, 2016 at 11:25 PM, Eric Sunshine wrote: > On Mon, Apr 25, 2016 at 2:40 PM, Pranit Bauva wrote: >> On Wed, Apr 13, 2016 at 10:57 PM, Eric Sunshine >> wrote: >>> Each of these patches should have a single conceptual purpose. It >>> seems, from the above explanation, that you're mix

Re: [PATCH v14 3/6] t0040-parse-options: improve test coverage

2016-04-27 Thread Eric Sunshine
On Mon, Apr 25, 2016 at 2:40 PM, Pranit Bauva wrote: > On Wed, Apr 13, 2016 at 10:57 PM, Eric Sunshine > wrote: >> Each of these patches should have a single conceptual purpose. It >> seems, from the above explanation, that you're mixing and mismatching >> bits of such changes between patches. >

Re: [PATCH v14 3/6] t0040-parse-options: improve test coverage

2016-04-25 Thread Pranit Bauva
On Wed, Apr 13, 2016 at 10:57 PM, Eric Sunshine wrote: > On Wed, Apr 13, 2016 at 4:59 AM, Pranit Bauva wrote: >> On Wed, Apr 13, 2016 at 10:56 AM, Eric Sunshine >> wrote: >>> On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva >>> wrote: +test_expect_success '--no-quiet sets quiet to 0' '

Re: [PATCH v14 3/6] t0040-parse-options: improve test coverage

2016-04-13 Thread Eric Sunshine
On Wed, Apr 13, 2016 at 4:59 AM, Pranit Bauva wrote: > On Wed, Apr 13, 2016 at 10:56 AM, Eric Sunshine > wrote: >> On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva wrote: >>> +test_expect_success '--no-quiet sets quiet to 0' ' >>> + test-parse-options --no-quiet >output 2>output.err && >> >>

Re: [PATCH v14 3/6] t0040-parse-options: improve test coverage

2016-04-13 Thread Pranit Bauva
On Wed, Apr 13, 2016 at 10:56 AM, Eric Sunshine wrote: > On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva wrote: >> Include tests to check for multiple levels of quiet and to check if the >> '--no-quiet' option sets it to 0. >> >> Signed-off-by: Pranit Bauva >> --- >> diff --git a/t/t0040-parse-opt

Re: [PATCH v14 3/6] t0040-parse-options: improve test coverage

2016-04-12 Thread Eric Sunshine
On Tue, Apr 12, 2016 at 7:02 PM, Pranit Bauva wrote: > Include tests to check for multiple levels of quiet and to check if the > '--no-quiet' option sets it to 0. > > Signed-off-by: Pranit Bauva > --- > diff --git a/t/t0040-parse-options.sh b/t/t0040-parse-options.sh > @@ -476,4 +476,41 @@ test_e

[PATCH v14 3/6] t0040-parse-options: improve test coverage

2016-04-12 Thread Pranit Bauva
Include tests to check for multiple levels of quiet and to check if the '--no-quiet' option sets it to 0. Signed-off-by: Pranit Bauva --- t/t0040-parse-options.sh | 37 + 1 file changed, 37 insertions(+) diff --git a/t/t0040-parse-options.sh b/t/t0040-parse-o