Re: [PATCH v10 4/4] test-config: add tests for the config_set API

2014-07-18 Thread Matthieu Moy
Junio C Hamano writes: > Tanay Abhra writes: > >> +test_expect_success 'proper error on non-existant files' ' >> +echo "Error (-1) reading configuration file non-existant-file." >expect >> && > > s/tant/tent/ perhaps? > cf. http://en.wiktionary.org/wiki/non-existant It seems so. My bad. >

Re: [PATCH v10 4/4] test-config: add tests for the config_set API

2014-07-18 Thread Junio C Hamano
Tanay Abhra writes: > +test_expect_success 'proper error on non-existant files' ' > + echo "Error (-1) reading configuration file non-existant-file." >expect > && s/tant/tent/ perhaps? cf. http://en.wiktionary.org/wiki/non-existant > +test_expect_success 'proper error on non-accessible fil

[PATCH v10 4/4] test-config: add tests for the config_set API

2014-07-18 Thread Tanay Abhra
Expose the `config_set` C API as a set of simple commands in order to facilitate testing. Add tests for the `config_set` API as well as for `git_config_get_*()` family for the usual config files. Signed-off-by: Matthieu Moy Signed-off-by: Tanay Abhra --- .gitignore| 1 + Makefile