Re: [PATCH v1 3/6] Per-file output for Porcelain Status V2

2016-07-22 Thread Junio C Hamano
Jeff Hostetler writes: >>> + case DIFF_STATUS_DELETED: >>> + d->porcelain_v2.mode_index = p->one->mode; >>> + hashcpy(d->porcelain_v2.sha1_index, p->one->sha1); >>> + break; >>> + >>> + case DIFF_STATUS_COPIED: >>> + case DIFF_STATUS_MODIFIED: >>> + case DIFF

Re: [PATCH v1 3/6] Per-file output for Porcelain Status V2

2016-07-21 Thread Jeff Hostetler
On 07/20/2016 05:31 PM, Junio C Hamano wrote: The code seems to assume that d->porcelain_v2.* fields are initialized earlier in the callchain to reasonable values (e.g. STATUS_ADDED case does not clear .mode_head to "missing"); I am not sure if that is easier to read or fill in all the values

Re: [PATCH v1 3/6] Per-file output for Porcelain Status V2

2016-07-21 Thread Johannes Schindelin
git shortlog" output. > > > Subject: Re: [PATCH v1 3/6] Per-file output for Porcelain Status V2 > > Subject: status: per-file output for --porcelain=v2 > > or something like that, perhaps? > > > This commit sets up version 2 porcelain status and > > defines th

Re: [PATCH v1 3/6] Per-file output for Porcelain Status V2

2016-07-20 Thread Junio C Hamano
Jeff Hostetler writes: > diff --git a/wt-status.c b/wt-status.c > index c19b52c..2d4829e 100644 > --- a/wt-status.c > +++ b/wt-status.c > @@ -406,6 +406,89 @@ static void wt_status_print_change_data(struct wt_status > *s, > strbuf_release(&twobuf); > } > > + > +/* Copy info for both sid

Re: [PATCH v1 3/6] Per-file output for Porcelain Status V2

2016-07-20 Thread Junio C Hamano
Jeff Hostetler writes: Just to avoid later headaches... please look at your commit titles and imagine how they will look when listed among 400+ other changes when they are included in a future release in "git shortlog" output. > Subject: Re: [PATCH v1 3/6] Per-file output for Por

[PATCH v1 3/6] Per-file output for Porcelain Status V2

2016-07-19 Thread Jeff Hostetler
This commit sets up version 2 porcelain status and defines the format of detail lines. This includes the usual XY and pathname fields. It adds the various file modes and SHAs and the rename score. For regular entries these values reflect the head, index and worktree. For unmerged entries these v