Re: [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange

2016-11-22 Thread Duy Nguyen
On Tue, Nov 22, 2016 at 8:13 PM, Christian Couder wrote: > So if we now mix things up just to avoid one more configuration > option, we could very well make things harder to develop, to > configure, to parse and to understand later, so it is not a trade off > worth making. OK since we're still in

Re: [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange

2016-11-22 Thread Christian Couder
On Tue, Nov 22, 2016 at 11:35 AM, Duy Nguyen wrote: [...] >>> In my opinion, "true" _is_ auto, which is a way to say "I trust you to >>> do the right thing, just re-split the index when it makes sense", "no" >>> is disabled of course. If the user wants to be specific, just write >>> "10" or some

Re: [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange

2016-11-22 Thread Duy Nguyen
On Fri, Nov 18, 2016 at 9:34 PM, Christian Couder wrote: > On Mon, Nov 7, 2016 at 10:38 AM, Duy Nguyen wrote: >> (sorry I got sick in the last few weeks and could not respond to this >> earlier) > > (Yeah, I have also been sick during the last few weeks.) > >> On Mon, Nov 7, 2016 at 4:44 AM, Chr

Re: [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange

2016-11-18 Thread Christian Couder
On Mon, Nov 7, 2016 at 10:38 AM, Duy Nguyen wrote: > (sorry I got sick in the last few weeks and could not respond to this earlier) (Yeah, I have also been sick during the last few weeks.) > On Mon, Nov 7, 2016 at 4:44 AM, Christian Couder > wrote: >> Le 6 nov. 2016 09:16, "Junio C Hamano" a é

Re: [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange

2016-11-07 Thread Duy Nguyen
(sorry I got sick in the last few weeks and could not respond to this earlier) On Mon, Nov 7, 2016 at 4:44 AM, Christian Couder wrote: > Le 6 nov. 2016 09:16, "Junio C Hamano" a écrit : >> >> Christian Couder writes: >> >> > I think it is easier for user to be able to just set core.splitIndex >

Re: [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange

2016-11-06 Thread Junio C Hamano
Christian Couder writes: > I think it is easier for user to be able to just set core.splitIndex > to true to enable split-index. You can have that exact benefit by making core.splitIndex to bool-or-more. If your default is 20%, take 'true' as if the user specified 20% and take 'false' as if the

Re: [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange

2016-11-04 Thread Christian Couder
On Tue, Nov 1, 2016 at 8:19 PM, Junio C Hamano wrote: > Christian Couder writes: > >> +splitIndex.maxPercentChange:: >> + When the split index feature is used, this specifies the >> + percent of entries the split index can contain compared to the >> + whole number of entries in both t

Re: [PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange

2016-11-01 Thread Junio C Hamano
Christian Couder writes: > Signed-off-by: Christian Couder > --- > Documentation/config.txt | 13 + > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/config.txt b/Documentation/config.txt > index 96521a4..380eeb8 100644 > --- a/Documentation/config.txt > +++ b/Docume

[PATCH v1 12/19] Documentation/config: add splitIndex.maxPercentChange

2016-10-23 Thread Christian Couder
Signed-off-by: Christian Couder --- Documentation/config.txt | 13 + 1 file changed, 13 insertions(+) diff --git a/Documentation/config.txt b/Documentation/config.txt index 96521a4..380eeb8 100644 --- a/Documentation/config.txt +++ b/Documentation/config.txt @@ -2763,6 +2763,19 @@ sh