Re: [PATCH v1 1/3] doc: commit: --fixup/--squash can take a commit revision

2016-08-16 Thread Philip Oakley
From: "Philip Oakley" From: "Junio C Hamano" "Philip Oakley" writes: I think the use of "commit" in an angle-bracket-pair in the label for the section, i.e. "--fixup=", has been considered to be clear enough to tell that you can use usual extended SHA-1 syntax to specify the commit you want

Re: [PATCH v1 1/3] doc: commit: --fixup/--squash can take a commit revision

2016-08-14 Thread Philip Oakley
From: "Junio C Hamano" "Philip Oakley" writes: I think the use of "commit" in an angle-bracket-pair in the label for the section, i.e. "--fixup=", has been considered to be clear enough to tell that you can use usual extended SHA-1 syntax to specify the commit you want to talk about, I cert

Re: [PATCH v1 1/3] doc: commit: --fixup/--squash can take a commit revision

2016-08-14 Thread Junio C Hamano
"Philip Oakley" writes: >> I think the >> use of "commit" in an angle-bracket-pair in the label for the >> section, i.e. "--fixup=", has been considered to be clear >> enough to tell that you can use usual extended SHA-1 syntax to >> specify the commit you want to talk about, > > I certainly hadn

Re: [PATCH v1 1/3] doc: commit: --fixup/--squash can take a commit revision

2016-08-14 Thread Philip Oakley
From: "Junio C Hamano" Philip Oakley writes: Be clearer that the --fixup/--squash options can take any of the gitrevisions methods of specifying a commit, not just a 'hash'. Signed-off-by: Philip Oakley --- ... @@ -81,15 +81,15 @@ OPTIONS --fixup=:: Construct a commit message for use with

Re: [PATCH v1 1/3] doc: commit: --fixup/--squash can take a commit revision

2016-08-14 Thread Junio C Hamano
Philip Oakley writes: > Be clearer that the --fixup/--squash options can take any of the > gitrevisions methods of specifying a commit, not just a 'hash'. > > Signed-off-by: Philip Oakley > --- > ... > @@ -81,15 +81,15 @@ OPTIONS > --fixup=:: > Construct a commit message for use with `reba

[PATCH v1 1/3] doc: commit: --fixup/--squash can take a commit revision

2016-08-14 Thread Philip Oakley
Be clearer that the --fixup/--squash options can take any of the gitrevisions methods of specifying a commit, not just a 'hash'. Signed-off-by: Philip Oakley --- v1 It's not immediately obvious what different forms the option can take. Spell out, and refer to the git revisions guide, that any of