Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-09 Thread Junio C Hamano
Roberto Tyley writes: > I've not personally run checkpatch.pl (as Peff mentioned, it's not > actually a documented part of the Git project's recommend contribution > workflow) - I'm still trying to understand whether it will restrict > it's errors to just the things that are introduced in a patch

Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-09 Thread Roberto Tyley
On 9 February 2016 at 18:42, Junio C Hamano wrote: > Lars Schneider writes: >> Jeff Merkey made me aware of http://kernelnewbies.org/FirstKernelPatch [2] >> where I found checkpatch.pl [3]. Would it make sense to check all commits >> that are not in next/master/maint with this script on Travis-CI

Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-09 Thread Ramsay Jones
On 09/02/16 17:47, Junio C Hamano wrote: > Jeff King writes: > >> Perhaps. I'm not sure that people actually use checkpatch.pl for git. >> >> Out of curiosity, I tried: >> >> mkdir out >> git format-patch -o out v2.6.0..v2.7.0 >> checkpatch.pl out/* >> >> It's rather noisy, and after skim

Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-09 Thread Stefan Beller
On Tue, Feb 9, 2016 at 10:42 AM, Junio C Hamano wrote: > Lars Schneider writes: > >> Jeff Merkey made me aware of http://kernelnewbies.org/FirstKernelPatch [2] >> where I found checkpatch.pl [3]. Would it make sense to check all commits >> that are not in next/master/maint with this script on Tra

Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-09 Thread Junio C Hamano
Lars Schneider writes: > Jeff Merkey made me aware of http://kernelnewbies.org/FirstKernelPatch [2] > where I found checkpatch.pl [3]. Would it make sense to check all commits > that are not in next/master/maint with this script on Travis-CI? That does not help very much. These changes are alre

Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-09 Thread Junio C Hamano
Jeff King writes: > Perhaps. I'm not sure that people actually use checkpatch.pl for git. > > Out of curiosity, I tried: > > mkdir out > git format-patch -o out v2.6.0..v2.7.0 > checkpatch.pl out/* > > It's rather noisy, and after skimming, I'd say (subjectively) that only > a small fractio

Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-09 Thread Jeff King
On Tue, Feb 09, 2016 at 11:06:17AM +0100, Lars Schneider wrote: > I collected the warnings from Junio's Make [1] script and merged them with > yours. This is the resulting warning list for clang and gcc: > > -Wdeclaration-after-statement -Wno-format-zero-length -Wold-style-definition > -Woverfl

Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-09 Thread Lars Schneider
On 08 Feb 2016, at 13:25, Jeff King wrote: > On Mon, Feb 08, 2016 at 09:59:18AM +0100, larsxschnei...@gmail.com wrote: > >> From: Lars Schneider >> >> The global Travis-CI environment variable CFLAGS did not override the >> CFLAGS variable in the makefile. Pass CFLAGS as make variable to >> o

Re: [PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-08 Thread Jeff King
On Mon, Feb 08, 2016 at 09:59:18AM +0100, larsxschnei...@gmail.com wrote: > From: Lars Schneider > > The global Travis-CI environment variable CFLAGS did not override the > CFLAGS variable in the makefile. Pass CFLAGS as make variable to > override it properly. Makes sense. > In addition to th

[PATCH v1] travis-ci: override CFLAGS properly, add -Wdeclaration-after-statement

2016-02-08 Thread larsxschneider
From: Lars Schneider The global Travis-CI environment variable CFLAGS did not override the CFLAGS variable in the makefile. Pass CFLAGS as make variable to override it properly. In addition to that, add '-Wdeclaration-after-statement' to make a Travis-CI build fail (because of '-Werror') if the