Re: [PATCH v1] git-instaweb: Add Python builtin http.server support

2019-01-27 Thread Junio C Hamano
"brian m. carlson" writes: > On Fri, Jan 25, 2019 at 05:22:45PM +0200, Arti Zirk wrote: >> This is the built in http server that Python comes with (like Ruby >> users have builtin webrick server). While it is possible to install >> something else, I don't think many casual git-instaweb users woul

Re: [PATCH v1] git-instaweb: Add Python builtin http.server support

2019-01-25 Thread brian m. carlson
On Fri, Jan 25, 2019 at 05:22:45PM +0200, Arti Zirk wrote: > This is the built in http server that Python comes with (like Ruby > users have builtin webrick server). While it is possible to install > something else, I don't think many casual git-instaweb users would do > it. > > I haven't looked

Re: [PATCH v1] git-instaweb: Add Python builtin http.server support

2019-01-25 Thread Arti Zirk
> > Could we call this "python3" instead, or provide some other way to > > communicate this to the user? > > Sounds like a good idea. Also would this be _the_ sole http server > implementation Python3 users would choose, or is it just a possible > one? What I am trying to get at is that we mig

Re: [PATCH v1] git-instaweb: Add Python builtin http.server support

2019-01-25 Thread Junio C Hamano
"brian m. carlson" writes: > I'm glad we're using Python 3 here, but I wonder if the name "python" > will lead people to think it will work with Python 2 as well. There are > people using up-to-date Git on systems like CentOS 6 and 7, where Python > 3 is not generally available. > > Could we call

Re: [PATCH v1] git-instaweb: Add Python builtin http.server support

2019-01-24 Thread brian m. carlson
On Thu, Jan 24, 2019 at 06:13:31PM +0200, Arti Zirk wrote: > With this patch it is possible to launch git-instaweb by using > Python 3 http.server CGI handler via `-d python` option. > > git-instaweb generates a small wrapper around the http.server > (in GIT_DIR/gitweb/) that address a limitation

Re: [PATCH v1] git-instaweb: Add Python builtin http.server support

2019-01-24 Thread Junio C Hamano
Arti Zirk writes: > With this patch it is possible to launch git-instaweb by using > Python 3 http.server CGI handler via `-d python` option. > > git-instaweb generates a small wrapper around the http.server > (in GIT_DIR/gitweb/) ... I know this follows an existing pattern (psgi and webrick als

[PATCH v1] git-instaweb: Add Python builtin http.server support

2019-01-24 Thread Arti Zirk
With this patch it is possible to launch git-instaweb by using Python 3 http.server CGI handler via `-d python` option. git-instaweb generates a small wrapper around the http.server (in GIT_DIR/gitweb/) that address a limitation of the CGI handler where CGI scripts have to be in a cgi-bin subdirec