Re: [PATCH v1] correct blame for files commited with CRLF

2016-04-05 Thread Torsten Bögershausen
On 05.04.16 23:12, Junio C Hamano wrote: > tbo...@web.de writes: > >> +git config core.autocrlf true && >> +mv crlfinrepo tmp && >> +git checkout crlfinrepo && >> +rm tmp && > > Why not just "rm -f crlfinrepo" and "git checkout crlfinrepo"? The intention was to get a new inode num

Re: [PATCH v1] correct blame for files commited with CRLF

2016-04-05 Thread Junio C Hamano
tbo...@web.de writes: > + git config core.autocrlf true && > + mv crlfinrepo tmp && > + git checkout crlfinrepo && > + rm tmp && Why not just "rm -f crlfinrepo" and "git checkout crlfinrepo"? > + git blame crlfinrepo >actual && > + grep "A U Thor" actual > +' > + > test_

Re: [PATCH v1] correct blame for files commited with CRLF

2016-04-05 Thread Junio C Hamano
tbo...@web.de writes: > This fix is completely independent of the rest of the series, > so break out 6/7 from tb/safe-crlf-output. Sounds sensible. It is somewhat sad and strange that we need to rely on what is in the index to show the current working tree state, but this makes the things more

[PATCH v1] correct blame for files commited with CRLF

2016-04-05 Thread tboegi
From: Torsten Bögershausen git blame reports lines as not "Not Committed Yet" when they have CRLF in the index, CRLF in the worktree and core.autocrlf is true. Since commit c48053 "new safer autocrlf handling", files that have CRLF in the index are not normalized at commit when core.autocrl is s