Re: [PATCH for NEXT v3 2/2] sub-process: refactor handshake to common function

2017-08-07 Thread Ben Peart
On 8/7/2017 2:17 PM, Jonathan Tan wrote: On Mon, 7 Aug 2017 19:51:04 +0200 Lars Schneider wrote: On 07 Aug 2017, at 19:21, Jonathan Tan wrote: On Sun, 6 Aug 2017 21:58:24 +0200 Lars Schneider wrote: + struct cmd2process *entry = (struct cmd2process *)subprocess; + return s

Re: [PATCH for NEXT v3 2/2] sub-process: refactor handshake to common function

2017-08-07 Thread Jonathan Tan
On Mon, 7 Aug 2017 19:51:04 +0200 Lars Schneider wrote: > > > On 07 Aug 2017, at 19:21, Jonathan Tan wrote: > > > > On Sun, 6 Aug 2017 21:58:24 +0200 > > Lars Schneider wrote: > > > >>> + struct cmd2process *entry = (struct cmd2process *)subprocess; > >>> + return subprocess_handshake(subpro

Re: [PATCH for NEXT v3 2/2] sub-process: refactor handshake to common function

2017-08-07 Thread Lars Schneider
> On 07 Aug 2017, at 19:21, Jonathan Tan wrote: > > On Sun, 6 Aug 2017 21:58:24 +0200 > Lars Schneider wrote: > >>> + struct cmd2process *entry = (struct cmd2process *)subprocess; >>> + return subprocess_handshake(subprocess, "git-filter", versions, NULL, >>> +

Re: [PATCH for NEXT v3 2/2] sub-process: refactor handshake to common function

2017-08-07 Thread Jonathan Tan
On Sun, 6 Aug 2017 21:58:24 +0200 Lars Schneider wrote: > > + struct cmd2process *entry = (struct cmd2process *)subprocess; > > + return subprocess_handshake(subprocess, "git-filter", versions, NULL, > > + capabilities, > > + &entry-

Re: [PATCH for NEXT v3 2/2] sub-process: refactor handshake to common function

2017-08-06 Thread Lars Schneider
> On 26 Jul 2017, at 20:17, Jonathan Tan wrote: > > Refactor, into a common function, the version and capability negotiation > done when invoking a long-running process as a clean or smudge filter. > This will be useful for other Git code that needs to interact similarly > with a long-running pr

[PATCH for NEXT v3 2/2] sub-process: refactor handshake to common function

2017-07-26 Thread Jonathan Tan
Refactor, into a common function, the version and capability negotiation done when invoking a long-running process as a clean or smudge filter. This will be useful for other Git code that needs to interact similarly with a long-running process. As you can see in the change to t0021, this commit ch