Re: [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path

2019-08-08 Thread Junio C Hamano
Jeff King writes: > On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote: > >> But a dash bug[*] causes it to instead expand to >> >> /3456789... >> >> The stream of symbols that makes up this function is hard for humans >> to follow, too. The complexity mostly comes from the r

Re: [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path

2019-08-08 Thread SZEDER Gábor
On Thu, Aug 08, 2019 at 11:35:38AM +, brian m. carlson wrote: > On 2019-08-08 at 09:37:33, Jeff King wrote: > > On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote: > > -- >8 -- > > Subject: [PATCH] t: reword comments for "local" test > > > > Commit 01d3a526ad (t: check whe

Re: [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path

2019-08-08 Thread brian m. carlson
On 2019-08-08 at 09:37:33, Jeff King wrote: > On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote: > -- >8 -- > Subject: [PATCH] t: reword comments for "local" test > > Commit 01d3a526ad (t: check whether the shell supports the "local" > keyword, 2017-10-26) added a test to gat

Re: [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path

2019-08-08 Thread brian m. carlson
On 2019-08-08 at 06:56:14, Jonathan Nieder wrote: > t1410.3 ("corrupt and checks") fails when run using dash versions > before 0.5.8, with a cryptic message: > > mv: cannot stat '.git/objects//e84adb2704cbd49549e52169b4043871e13432': > No such file or directory > > The function generating

Re: [PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path

2019-08-08 Thread Jeff King
On Wed, Aug 07, 2019 at 11:56:14PM -0700, Jonathan Nieder wrote: > But a dash bug[*] causes it to instead expand to > > /3456789... > > The stream of symbols that makes up this function is hard for humans > to follow, too. The complexity mostly comes from the repeated use of > the express

[PATCH bc/hash-independent-tests-part-4] t: decrease nesting in test_oid_to_path

2019-08-07 Thread Jonathan Nieder
t1410.3 ("corrupt and checks") fails when run using dash versions before 0.5.8, with a cryptic message: mv: cannot stat '.git/objects//e84adb2704cbd49549e52169b4043871e13432': No such file or directory The function generating that path: test_oid_to_path () { echo