Re: [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm

2013-06-18 Thread Matthieu Moy
Benoît Person writes: > On 17 June 2013 09:12, Matthieu Moy wrote: Also, it seems to be only part of the solution. With your change, from contrib/mw-to-git/ and after running only "make", ./git-mw takes the installed version of GitMediawiki.pm in priority ../../bin-

Re: [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm

2013-06-18 Thread Matthieu Moy
Benoît Person writes: >>From my point of view, this could definitely be improved from: >> - perlcritic -2 *.perl >> + perlcritic -2 *.perl >> \ No newline at end of file > to something like that: >> - perlcritic -2 *.perl >> + perlcritic -2 *.perl >> \ removed newline at end of fi

Re: [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm

2013-06-18 Thread Benoît Person
On 17 June 2013 09:12, Matthieu Moy wrote: >>> Also, it seems to be only part of the solution. With your change, from >>> contrib/mw-to-git/ and after running only "make", >>> >>> ./git-mw takes the installed version of GitMediawiki.pm in priority >>> >>> ../../bin-wrappers/git takes the installed

Re: [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm

2013-06-17 Thread Matthieu Moy
Benoît Person writes: > On 16 June 2013 22:18, Matthieu Moy wrote: >> benoit.per...@ensimag.fr writes: >> >>> changes from the V2: >>> - Add a way to test, without installation, code that uses GitMediawiki.pm. >> >> This still needs to be documented, even very quickly, somewhere in the >> code

Re: [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm

2013-06-16 Thread Benoît Person
On 16 June 2013 22:18, Matthieu Moy wrote: > benoit.per...@ensimag.fr writes: > >> changes from the V2: >> - Add a way to test, without installation, code that uses GitMediawiki.pm. > > This still needs to be documented, even very quickly, somewhere in the > code (e.g a comment in the Makefile).

Re: [PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm

2013-06-16 Thread Matthieu Moy
benoit.per...@ensimag.fr writes: > changes from the V2: > - Add a way to test, without installation, code that uses GitMediawiki.pm. This still needs to be documented, even very quickly, somewhere in the code (e.g a comment in the Makefile). > -build install clean: > +copy_pm: > + cp $(GIT

[PATCH V3 1/4] git-mw: Introduction of GitMediawiki.pm

2013-06-15 Thread benoit . person
From: Benoit Person GitMediawiki.pm enable code factoring between several scripts in mw-to-git. To make it usable in scripts (ie: accessible in @INC) it adds two targets (copy_pm & install_pm) into the Makefile, one for tests and one for installation. Signed-off-by: Benoit Person Signed-off-by