Re: [PATCH 8/8] wrap_in_html(): process message in bulk rather than line-by-line

2012-12-02 Thread Michael Haggerty
On 12/02/2012 10:25 AM, Junio C Hamano wrote: > Michael Haggerty writes: > >> Nevertheless, the old code was even *more* broken because it added a >> "" regardless of whether the separator line had been seen,... > > OK. I'll rewrite the tail-end of the original log message to read: > > The

Re: [PATCH 8/8] wrap_in_html(): process message in bulk rather than line-by-line

2012-12-02 Thread Junio C Hamano
Michael Haggerty writes: > Nevertheless, the old code was even *more* broken because it added a > "" regardless of whether the separator line had been seen,... OK. I'll rewrite the tail-end of the original log message to read: The old code would have created invalid output when there was no

Re: [PATCH 8/8] wrap_in_html(): process message in bulk rather than line-by-line

2012-11-30 Thread Michael Haggerty
On 11/29/2012 10:33 PM, Junio C Hamano wrote: > Michael Haggerty writes: > >> Now that we can xml-quote an arbitrary string in O(N), there is no >> reason to process the message line by line. This change saves lots of >> memory allocations and copying. >> >> The old code would have created inval