Re: [PATCH 76/76] am: avoid diff_opt_parse()

On Fri, Jan 18, 2019 at 3:10 AM Johannes Schindelin wrote: > > Hi Duy, > > the change itself looks good, but... > > On Thu, 17 Jan 2019, Nguyễn Thái Ngọc Duy wrote: > > > diff_opt_parse() is a heavy hammer to just set diff filter. But it's > > the only way because of the diff_status_letters[] mapp

Re: [PATCH 76/76] am: avoid diff_opt_parse()

Hi Duy, the change itself looks good, but... On Thu, 17 Jan 2019, Nguyễn Thái Ngọc Duy wrote: > diff_opt_parse() is a heavy hammer to just set diff filter. But it's > the only way because of the diff_status_letters[] mapping. Add a new > API to set diff filter and use it in git-am. diff_opt_pars

[PATCH 76/76] am: avoid diff_opt_parse()

diff_opt_parse() is a heavy hammer to just set diff filter. But it's the only way because of the diff_status_letters[] mapping. Add a new API to set diff filter and use it in git-am. diff_opt_parse()'s only remaining call site in revision.c will be gone soon and having it here just because of git-a