Re: [PATCH 74/76] range-diff: use parse_options() instead of diff_opt_parse()

nOn Fri, Jan 18, 2019 at 2:46 AM Stefan Beller wrote: > > and we get a > > looong 'git range-diff -h' > > This is an interesting tidbit to put into the commit message. > > range-diff is interesting in that in it is unclear where the options > should take effect. My mental model of range-diff is >

Re: [PATCH 74/76] range-diff: use parse_options() instead of diff_opt_parse()

On Thu, Jan 17, 2019 at 5:12 AM Nguyễn Thái Ngọc Duy wrote: > > Diff's internal option parsing is now done with 'struct option', which > makes it possible to combine all diff options to range-diff and parse > everything all at once. Parsing code becomes simpler, Cool. I like the series up to here

[PATCH 74/76] range-diff: use parse_options() instead of diff_opt_parse()

Diff's internal option parsing is now done with 'struct option', which makes it possible to combine all diff options to range-diff and parse everything all at once. Parsing code becomes simpler, and we get a looong 'git range-diff -h' Signed-off-by: Nguyễn Thái Ngọc Duy --- builtin/range-diff.c