Re: [PATCH 7/8] commit-graph write: don't die if the existing graph is corrupt

2019-02-23 Thread Eric Sunshine
On Fri, Feb 22, 2019 at 6:13 PM Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh > > @@ -408,7 +414,7 @@ test_expect_success 'detect permission problem' ' > > # "chmod 000 file" does not yield EACCES on e.g. "cat fil

Re: [PATCH 7/8] commit-graph write: don't die if the existing graph is corrupt

2019-02-22 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > When the commit-graph is written we end up calling > parse_commit(). This will in turn invoke code that'll consult the > existing commit-graph about the commit, if the graph is corrupted we > die. Irony ;-). > Change the "commit-graph write" codepath to use a

[PATCH 7/8] commit-graph write: don't die if the existing graph is corrupt

2019-02-21 Thread Ævar Arnfjörð Bjarmason
When the commit-graph is written we end up calling parse_commit(). This will in turn invoke code that'll consult the existing commit-graph about the commit, if the graph is corrupted we die. We thus get into a state where a failing "commit-graph verify" can't be followed-up with a "commit-graph wr